feat: add ExecCollectValuesWatch #188
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new function, ExecCollectValuesWatch, to asynchronously collect values from a directive and trigger callbacks on value changes.
- Implements add, remove, and dispose handlers with a broadcast mechanism.
- Adds a dedicated goroutine to execute callbacks based on changes and idle status.
Comments suppressed due to low confidence (1)
bus/multi.go:315
- [nitpick] The callback goroutine stops watching on error. Consider updating the function documentation to clearly state that an error returned by the callback terminates further monitoring.
return // Stop on error
paralin
force-pushed
the
collect-values-watch
branch
from
e6701c8 to
8ffa7de
Compare
Signed-off-by: Christian Stewart <[email protected]>
paralin
force-pushed
the
collect-values-watch
branch
from
8ffa7de to
9bdf592
Compare
|
merged manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.